• Jakob Gruber's avatar
    [regexp] Fix invalid DCHECK in named capture logic · 5d5a6595
    Jakob Gruber authored
    The `capture_ix` refers to all captures while `capture_count` only
    refers to named captures. Clarified by renaming `capture_count` to
    `named_capture_count` and removing the incorrect part of the DCHECK.
    
    The `>= 1` part of the condition must still hold since named captures
    can only refer to explicit capture groups, which start at index 1.
    
    Tbr: petermarshall@chromium.org
    Bug: chromium:1018592
    Change-Id: If8a26f6661ba0483d585f74270b3b4a3853e2ca8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886810Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64629}
    5d5a6595
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...