• Clemens Backes's avatar
    Reland "[wasm] Prevent breakpoints on nonbreakable positions" · 5cf61684
    Clemens Backes authored
    This is an unmodified reland of 3c98a2a3.
    The actual issue was fixed in https://crrev.com/c/1926769.
    
    Original change's description:
    > [wasm] Prevent breakpoints on nonbreakable positions
    >
    > If a breakpoint is set on a non-breakable position, the wasm interpreter
    > just stores the value 0xFF (kInternalBreakpoint) in the function body
    > (actually, a copy of the function body). This might overwrite immediates
    > and cause subsequent failures in the wasm interpreter.
    >
    > In JavaScript, breakpoints are just forwarded to the next breakable
    > position. This CL implements the same for WebAssembly.
    > A cctest tests this behavior, and the existing
    > wasm-stepping-byte-offsets.js inspector test is extended to also set the
    > breakpoint within an i32 constant immediate.
    >
    > R=leese@chromium.org, mstarzinger@chromium.org
    > CC=​bmeurer@chromium.org
    >
    > Bug: chromium:1025184
    > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65070}
    
    Bug: chromium:1025184
    Change-Id: I5e16df645bbacf039b7a5e55a0c2a64cdb4c6a32
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926152
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65093}
    5cf61684
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...