• Benedikt Meurer's avatar
    [inspector] Set limit for Wasm wire byte transfer via CDP. · 7842920a
    Benedikt Meurer authored
    The `Debugger.getScriptSource()` and `Debugger.getWasmBytecode()`
    methods in the CDP return Wasm wire bytes as protocol::Binary, which is
    send as Base64-encoded JSON string in the communication to the DevTools
    front-end, and hence leads to either crashing the renderer that is being
    debugged or the renderer that's running the front-end if we allow
    arbitrarily huge Wasm byte sequences here. This CL introduces a limit,
    based on the maximum allowed string length, to avoid the crash and
    instead signal a proper error to the DevTools front-end.
    
    Bug: chromium:1099680
    Change-Id: I356d617301d17a4012f7f845773cf14e6ad1e4a7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270174
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68560}
    7842920a
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...