• Manos Koukoutos's avatar
    [wasm] Use isorecursive canonical types for call_indirect · 4f0ef8c3
    Manos Koukoutos authored
    Currently, we canonicalize types for call_indirect by looking in the
    current module for a signature of the same shape. This is not enough
    as of wasm-gc. Instead, the canonical identifier representing a type
    has to be computed via isorecursive canonicalization.
    This change is implemented behind a flag for now.
    Future work: Also integrate export wrappers with isorecursive
    canonical types. We need to store wrappers in instance-independent
    storage.
    
    Drive-by:
    - Always emit type check for call_indirect. We did not emit a check
      only when typed-function-references was enabled, but not gc. This
      is not something that will be possible long-term.
    - Fix some wasm cctests.
    
    Bug: v8:7748
    Change-Id: I7cced187009ac148c833dff5e720a8bb9a717e68
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784600Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82064}
    4f0ef8c3
Name
Last commit
Last update
..
baseline Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
assembler-buffer-cache.cc Loading commit data...
assembler-buffer-cache.h Loading commit data...
branch-hint-map.h Loading commit data...
c-api.cc Loading commit data...
c-api.h Loading commit data...
canonical-types.cc Loading commit data...
canonical-types.h Loading commit data...
code-space-access.cc Loading commit data...
code-space-access.h Loading commit data...
compilation-environment.h Loading commit data...
constant-expression-interface.cc Loading commit data...
constant-expression-interface.h Loading commit data...
constant-expression.cc Loading commit data...
constant-expression.h Loading commit data...
decoder.h Loading commit data...
function-body-decoder-impl.h Loading commit data...
function-body-decoder.cc Loading commit data...
function-body-decoder.h Loading commit data...
function-compiler.cc Loading commit data...
function-compiler.h Loading commit data...
graph-builder-interface.cc Loading commit data...
graph-builder-interface.h Loading commit data...
jump-table-assembler.cc Loading commit data...
jump-table-assembler.h Loading commit data...
leb-helper.h Loading commit data...
local-decl-encoder.cc Loading commit data...
local-decl-encoder.h Loading commit data...
memory-tracing.cc Loading commit data...
memory-tracing.h Loading commit data...
module-compiler.cc Loading commit data...
module-compiler.h Loading commit data...
module-decoder-impl.h Loading commit data...
module-decoder.cc Loading commit data...
module-decoder.h Loading commit data...
module-instantiate.cc Loading commit data...
module-instantiate.h Loading commit data...
names-provider.cc Loading commit data...
names-provider.h Loading commit data...
object-access.h Loading commit data...
signature-map.cc Loading commit data...
signature-map.h Loading commit data...
simd-shuffle.cc Loading commit data...
simd-shuffle.h Loading commit data...
stacks.h Loading commit data...
streaming-decoder.cc Loading commit data...
streaming-decoder.h Loading commit data...
string-builder-multiline.h Loading commit data...
string-builder.h Loading commit data...
struct-types.h Loading commit data...
sync-streaming-decoder.cc Loading commit data...
value-type.cc Loading commit data...
value-type.h Loading commit data...
wasm-arguments.h Loading commit data...
wasm-code-manager.cc Loading commit data...
wasm-code-manager.h Loading commit data...
wasm-constants.h Loading commit data...
wasm-debug.cc Loading commit data...
wasm-debug.h Loading commit data...
wasm-disassembler-impl.h Loading commit data...
wasm-disassembler.cc Loading commit data...
wasm-disassembler.h Loading commit data...
wasm-engine.cc Loading commit data...
wasm-engine.h Loading commit data...
wasm-external-refs.cc Loading commit data...
wasm-external-refs.h Loading commit data...
wasm-feature-flags.h Loading commit data...
wasm-features.cc Loading commit data...
wasm-features.h Loading commit data...
wasm-import-wrapper-cache.cc Loading commit data...
wasm-import-wrapper-cache.h Loading commit data...
wasm-init-expr.cc Loading commit data...
wasm-init-expr.h Loading commit data...
wasm-js.cc Loading commit data...
wasm-js.h Loading commit data...
wasm-limits.h Loading commit data...
wasm-linkage.h Loading commit data...
wasm-module-builder.cc Loading commit data...
wasm-module-builder.h Loading commit data...
wasm-module-sourcemap.cc Loading commit data...
wasm-module-sourcemap.h Loading commit data...
wasm-module.cc Loading commit data...
wasm-module.h Loading commit data...
wasm-objects-inl.h Loading commit data...
wasm-objects.cc Loading commit data...
wasm-objects.h Loading commit data...
wasm-objects.tq Loading commit data...
wasm-opcodes-inl.h Loading commit data...
wasm-opcodes.cc Loading commit data...
wasm-opcodes.h Loading commit data...
wasm-result.cc Loading commit data...
wasm-result.h Loading commit data...
wasm-serialization.cc Loading commit data...
wasm-serialization.h Loading commit data...
wasm-subtyping.cc Loading commit data...
wasm-subtyping.h Loading commit data...
wasm-tier.h Loading commit data...
wasm-value.h Loading commit data...