• littledan's avatar
    Avoid calling out to JS during stack overflow · 5975c47a
    littledan authored
    If an exception is thrown when there is a Promise being created, the Promise
    catch prediction code would call into a part implemented in JavaScript to see if
    the Promise has a catch handler. If it is not possible to call back into JS,
    e.g., due to a stack overflow, then this would lead to a crash. This patch
    "speculates" that, if it's impossible to call back into JavaScript, then the
    error is unhandled, avoding the issue. In a future patch, the catch prediction
    logic should be entirely written in C++, but this patch adds a minimal fix to
    be more friendly to backports.
    
    BUG=chromium:662935
    R=jgruber
    
    Review-Url: https://codereview.chromium.org/2487833002
    Cr-Commit-Position: refs/heads/master@{#40851}
    5975c47a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...