• Michael Stanton's avatar
    Revert "[Builtins] Array.prototype.forEach perf regression on dictionaries." · 6da8e1f9
    Michael Stanton authored
    This reverts commit 34625fdb.
    
    Reason for revert: Test caused timeout, investigating.
    
    Original change's description:
    > [Builtins] Array.prototype.forEach perf regression on dictionaries.
    > 
    > An unnecessary call to ToString() on the array index caused trips to
    > the runtime. The fix also includes performance micro-benchmarks so
    > we'll have a harder time regressing this case in future.
    > 
    > Bug: v8:8112
    > Change-Id: Iada5bd2e3c6d2246fb1225e7094f3d9c66ddafbd
    > Reviewed-on: https://chromium-review.googlesource.com/1206355
    > Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#55653}
    
    TBR=mvstanton@chromium.org,tebbi@chromium.org
    
    Change-Id: I21de9b9b33edf03f2173f579c4ba0fc3dfd8ff88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8112
    Reviewed-on: https://chromium-review.googlesource.com/1209288Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55681}
    6da8e1f9
Name
Last commit
Last update
..
Array Loading commit data...
ArrayLiteralInitialSpreadLargeHoley Loading commit data...
ArrayLiteralInitialSpreadLargePacked Loading commit data...
ArrayLiteralInitialSpreadSmallHoley Loading commit data...
ArrayLiteralInitialSpreadSmallPacked Loading commit data...
ArrayLiteralSpread Loading commit data...
ArraySort Loading commit data...
AsyncAwait Loading commit data...
BytecodeHandlers Loading commit data...
Classes Loading commit data...
Closures Loading commit data...
Collections Loading commit data...
DataView Loading commit data...
Exceptions Loading commit data...
ExpressionDepth Loading commit data...
ForLoops Loading commit data...
Generators Loading commit data...
Inspector Loading commit data...
Iterators Loading commit data...
Keys Loading commit data...
ManyClosures Loading commit data...
Modules Loading commit data...
Numbers Loading commit data...
Object Loading commit data...
ObjectLiteralSpread Loading commit data...
Parsing Loading commit data...
PropertyQueries Loading commit data...
Proxies Loading commit data...
RegExp Loading commit data...
RestParameters Loading commit data...
Scope Loading commit data...
SixSpeed Loading commit data...
SpreadCalls Loading commit data...
SpreadCallsGeneral Loading commit data...
StringIterators Loading commit data...
Strings Loading commit data...
Templates Loading commit data...
TurboFan Loading commit data...
TypedArrays Loading commit data...
JSTests.json Loading commit data...
OWNERS Loading commit data...
RegExp.json Loading commit data...
SixSpeed.json Loading commit data...
base.js Loading commit data...