• cbruni's avatar
    Reland of [runtime] Do not use the enum-cache for non-prototype objects.... · 5569e270
    cbruni authored
    Reland of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1619803003/ )
    
    Reason for revert:
    the deopt issues have been taken care of by benedikt
    
    Original issue's description:
    > Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #10 id:180001 of https://codereview.chromium.org/1608523002/ )
    >
    > Reason for revert:
    > tanks for-in significantly
    >
    > Original issue's description:
    > > [runtime] Do not use the enum-cache for keys retrieval.
    > >
    > > Currently we fail to properly handle shadowed properties. If the
    > > receiver defines a non-enumerable property that reappears on the
    > > prototype as enumerable it incorrectly shows up in [[Enumerate]].
    > > By extending the KeyAccumulator to track non-enumerable properties
    > > we can now properly filter them out when seeing them further up in
    > > the prototype-chain.
    > >
    > > BUG=v8:705
    > > LOG=y
    > >
    > > Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7
    > > Cr-Commit-Position: refs/heads/master@{#33405}
    >
    > TBR=jkummerow@chromium.org,bmeurer@chromium.org
    > # Not skipping CQ checks because original CL landed more than 1 days ago.
    > BUG=v8:705
    > LOG=n
    >
    > Committed: https://crrev.com/6e0573c6fff1c3041bab106d1197ab1b64aa9a6a
    > Cr-Commit-Position: refs/heads/master@{#33443}
    
    TBR=jkummerow@chromium.org,bmeurer@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:705
    
    Review URL: https://codereview.chromium.org/1612413003
    
    Cr-Commit-Position: refs/heads/master@{#33458}
    5569e270
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...