• Aleksey Kozyatinskiy's avatar
    Revert "[debug] introduced runtime side effect check" · 539a2443
    Aleksey Kozyatinskiy authored
    This reverts commit 7a2c3713.
    
    Reason for revert: msan is broken
    
    Original change's description:
    > [debug] introduced runtime side effect check
    > 
    > This CL demonstrates minimum valuable addition to existing debug evaluate
    > without side effects mechanism.
    > With this CL user can evaluate expressions like:
    > [a,b] // create any kind of temporary array literals
    > [a,b].reduce((x,y) => x + y, 0); // use reduce method
    > [1,2,3].fill(2); // change temporary arrays
    > 
    > The core idea: any change of the object created during evaluation without
    > side effects is side effect free. As soon as we try to store this temporary
    > object to object existed before evaluation we will terminate execution.
    > 
    > Implementation:
    > - track all objects allocated during evaluation and mark them as temporary,
    > - patch all bytecodes which change objects.
    > 
    > A little more details (including performance analysis): [1].
    > 
    > [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit#
    > 
    > Bug: v8:7588
    > Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111
    > Reviewed-on: https://chromium-review.googlesource.com/972615
    > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#52370}
    
    TBR=ulan@chromium.org,rmcilroy@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,leszeks@chromium.org
    
    Change-Id: Ied1739c6308b13a4981189e0999f5912316cf456
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7588
    Reviewed-on: https://chromium-review.googlesource.com/996135Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52371}
    539a2443
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...