• Michael Lippautz's avatar
    cppgc: Check for correct base class inheritance · 143e6a74
    Michael Lippautz authored
    The only valid way to define a GCed type T is by inheriting from
    GarbageCollected<T>. Since this is prone to typos (see tests), add a
    simple check that covers most interesting use cases.
    
    The static assert covers
      A -> B -> GarbageCollected<C>
    
    The static assert does not cover
     A -> B -> C -> GarbageCollected<B>
    
    (In order to do so, we would need __direct_bases() support which is
    not yet available for C++.)
    
    Bug: pdfium:1670, chromium:1056170
    Change-Id: I494de48992f8ba9a1f0f9daad60584d828717403
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810415Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73854}
    143e6a74
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...