• Jakob Gruber's avatar
    [regexp] Fix invalid DCHECK in named capture logic · 5d5a6595
    Jakob Gruber authored
    The `capture_ix` refers to all captures while `capture_count` only
    refers to named captures. Clarified by renaming `capture_count` to
    `named_capture_count` and removing the incorrect part of the DCHECK.
    
    The `>= 1` part of the condition must still hold since named captures
    can only refer to explicit capture groups, which start at index 1.
    
    Tbr: petermarshall@chromium.org
    Bug: chromium:1018592
    Change-Id: If8a26f6661ba0483d585f74270b3b4a3853e2ca8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886810Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64629}
    5d5a6595
Name
Last commit
Last update
..
OWNERS Loading commit data...
runtime-array.cc Loading commit data...
runtime-atomics.cc Loading commit data...
runtime-bigint.cc Loading commit data...
runtime-classes.cc Loading commit data...
runtime-collections.cc Loading commit data...
runtime-compiler.cc Loading commit data...
runtime-date.cc Loading commit data...
runtime-debug.cc Loading commit data...
runtime-forin.cc Loading commit data...
runtime-function.cc Loading commit data...
runtime-futex.cc Loading commit data...
runtime-generator.cc Loading commit data...
runtime-internal.cc Loading commit data...
runtime-interpreter.cc Loading commit data...
runtime-intl.cc Loading commit data...
runtime-literals.cc Loading commit data...
runtime-module.cc Loading commit data...
runtime-numbers.cc Loading commit data...
runtime-object.cc Loading commit data...
runtime-operators.cc Loading commit data...
runtime-promise.cc Loading commit data...
runtime-proxy.cc Loading commit data...
runtime-regexp.cc Loading commit data...
runtime-scopes.cc Loading commit data...
runtime-strings.cc Loading commit data...
runtime-symbol.cc Loading commit data...
runtime-test.cc Loading commit data...
runtime-typedarray.cc Loading commit data...
runtime-utils.h Loading commit data...
runtime-wasm.cc Loading commit data...
runtime.cc Loading commit data...
runtime.h Loading commit data...