• Kim-Anh Tran's avatar
    [debugger] Fix step out when instrumentation breaks are turned on · 51458608
    Kim-Anh Tran authored
    When triggering a step out action, we check whether we already
    are at a return or suspend location. If not, we first flood all
    return positions with breakpoints, set the fast_forward_to_return_
    flag and continue.
    
    With the new way of reporting instrumentation breakpoints, we now
    may get into the situation where we stopped on an instrumentation,
    but may still need to continue until we reach the return point for
    the step out. This CL fixes a bug in which we ran into a DCHECK
    that expected us to stop on a return location (since
    fast_forward_to_return_ is set to true), but we didn't.
    
    Drive-by: adapt other stepping tests to properly wait for all pauses
    
    Bug: chromium:1229541
    Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79226}
    51458608
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...