• Leszek Swirski's avatar
    [identity-map] Remove double-lookups in IdentityMap · 4e7c99ab
    Leszek Swirski authored
    Remove the pattern of calling 'Find' followed by 'Set' for IdentityMap,
    with a single 'FindOrInsert' that explicitly returns whether an existing
    entry was found, or the entry was inserted. This replaces 'Get', which
    would return either an initialised or uninitialised entry (and callers
    would rely on default initialisation to check this).
    
    Also replace 'Set' with 'Insert', which explicitly requires that the
    element didn't exist before. This matches expectations where it was
    used (where those weren't replaced wholesale with 'FindOrInsert'), and
    makes the naming consistent with 'FindOrInsert'.
    
    Change-Id: I8fb76f4ac14fb92b88474965aafb1ace5fb79145
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2443135
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70300}
    4e7c99ab
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...