• Georg Neis's avatar
    [turbofan] Fix CHECK failure in graph verifier · 8c0b68e3
    Georg Neis authored
    ForInNext can get lowered to a low-level call to the ForInFilter
    builtin. We currently type low-level Call nodes simply as Any, leading
    to a CHECK failure when the verifier expects a primitive.
    
    This CL fixes the issue simply by manually setting the type as part of
    the lowering. An alternative would be to have the Call typing inspect
    its input similar to what the JSCall typing does. We can consider this
    if we hit the same issue in other cases.
    
    Bug: chromium:1102053
    Change-Id: I6682d8cf95c6a3ebaff9c8de677aa20ca676573f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282523Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68688}
    8c0b68e3
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...