• Manos Koukoutos's avatar
    [wasm-gc][bug] Fix signature canonicalization · 4d9d8518
    Manos Koukoutos authored
    We used not to emit canonical indexes for arrays and structs into
    WasmModule::signature_ids, which resulted in signature_ids not referring
    to the correct type indices in a WasmModule.
    
    Changes:
    - Rename signature_ids to canonical_type_ids.
    - Emit trivial canonical type ids for structs and arrays.
    - Add a test to catch the existing bug.
    - Improve DCHECKs for module type accessors.
    
    Bug: v8:7748
    Change-Id: I67ad58865e35b459b21db12557564b652035db75
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2444989
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70318}
    4d9d8518
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...