• Camillo Bruni's avatar
    Reland "[runtime] Use Isolate::ThrowAt with MessageLocation" · 447915ef
    Camillo Bruni authored
    This is a reland of eb6b4ce1
    
    Skip test that serializes Error which references a Script. All errors
    created by ThrowAt store the current Script under the
    error_script_symbol.
    
    Original change's description:
    > [runtime] Use Isolate::ThrowAt with MessageLocation
    >
    > Fix various missing source positions when reporting parse and compile
    > errors. Namely this fixes missing source positions when having invalid
    > module imports.
    >
    > - Use Isolate::ThrowAt with valid MessageLocation objects
    > - Change public Isolate::Throw to no longer accept MessageLocation to
    >   avoid misues
    > - Introduce private Isolate::ThrowInternal that accepts MessageLocation
    >
    > Bug: v8:6513
    > Change-Id: I3ee633c9fff8c9d361bddb37f56e28a50c280ec1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2467839
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70623}
    
    Bug: v8:6513
    Change-Id: Icba74f74178e28fbda0fd0c237eeb7bacbc33570
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487123Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70741}
    447915ef
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
external-pointer-table.cc Loading commit data...
external-pointer-table.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
local-isolate-inl.h Loading commit data...
local-isolate.cc Loading commit data...
local-isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...