• Tobias Tebbi's avatar
    Reland^5 "[flags] warn about contradictory flags" · 0832a109
    Tobias Tebbi authored
    This is a reland of 2000aea5
    Changes compared to last reland:
    - Add rule in variants.py for --enable_experimental_regexp_engine.
    - Make sure --abort-on-contradictory-flags works as well as --fuzzing
      to disable the checking for fuzzers, including for d8 flags.
    
    Original change's description:
    > Reland^4 "[flags] warn about contradictory flags"
    >
    > This is a reland of 0ba115e6
    > Changes compared to last reland:
    > - Fix Python code trying to write to expected_outcomes, which is now a
    >   computed property.
    > - Fix remaining place in d8.cc that ignored the --fuzzing flag.
    > - Expect flag contradictions for --cache in code_serializer variant.
    >
    > Original change's description:
    > > Reland^3 "[flags] warn about contradictory flags"
    > >
    > > Changes:
    > > - Also allow second parameter influenced by --cache to be reassigned.
    > > - Fix --stress-opt to only --always-opt in the last iteration as before.
    > >
    > > Original change's description:
    > > > Reland^2 "[flags] warn about contradictory flags"
    > > >
    > > > This is a reland of d8f8a7e2
    > > > Change compared to last reland:
    > > > - Do not check for d8 flag contradictions in the presence of --fuzzing
    > > > - Allow identical re-declaration of --cache=*
    > > >
    > > > Original change's description:
    > > > > Reland "[flags] warn about contradictory flags"
    > > > >
    > > > > This is a reland of b8f91666
    > > > > Difference to previous CL: Additional functionality to specify
    > > > > incompatible flags based on GN variables and extra-flags, used
    > > > > to fix the issues that came up on the waterfall.
    > > > >
    > > > > This also changes the rules regarding repeated flags: While
    > > > > explicitly repeated flags are allowed for boolean values as long
    > > > > as they are identical, repeated flags or explicit flags in the
    > > > > presence of an active implication are disallowed for non-boolean
    > > > > flags. The latter simplifies specifying conflict rules in
    > > > > variants.py. Otherwise a rule like
    > > > >
    > > > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
    > > > >   "--gc-interval=*": ["--gc-interval=*"],
    > > > > }
    > > > >
    > > > > wouldn't work because specifying the same GC interval twice
    > > > > wouldn't actually count as a conflict. This was an issue with
    > > > > test/mjsunit/wasm/gc-buffer.js, which specifies
    > > > > --gc-interval=500 exactly like the extra flag by the stress bot.
    > > > >
    > > > > Also, this now expands contradictory flags checking to d8 flags
    > > > > for consistency.
    > > > >
    > > > > Original change's description:
    > > > > > [flags] warn about contradictory flags
    > > > > >
    > > > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/
    > > > > >
    > > > > > Bug: v8:10577
    > > > > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792
    > > > > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > > > > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > > > > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > > > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
    > > > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > > > Cr-Commit-Position: refs/heads/master@{#68168}
    > > > >
    > > > > Bug: v8:10577
    > > > > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115
    > > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
    > > > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > > > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#68989}
    > > >
    > > > Bug: v8:10577
    > > > Change-Id: I31d2794d4f9ff630f3444210100c64d67d881276
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339464
    > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#69339}
    > >
    > > Bug: v8:10577
    > > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    > > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    > > Change-Id: I4a69dc57a102782cb453144323e3752ac8278624
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352770
    > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#69433}
    >
    > Change-Id: Ib6d2aeb495210f581ac671221c265df58e8e5e70
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2398640
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Tamer Tas <tmrts@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69954}
    
    Bug: v8:10577
    TBR: clemensb@chromium.org, tmrts@chromium.org
    Change-Id: Iab2d32cdcc2648934fc52255ccf3ae3ec9ca4d9b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416386Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70000}
    0832a109
Name
Last commit
Last update
..
loop-stack-check.js Loading commit data...
regress-02256.js Loading commit data...
regress-02256b.js Loading commit data...
regress-02862.js Loading commit data...
regress-1010272.js Loading commit data...
regress-10126-streaming.js Loading commit data...
regress-10126.js Loading commit data...
regress-1014798.js Loading commit data...
regress-1016515.js Loading commit data...
regress-1026680.js Loading commit data...
regress-1027410.js Loading commit data...
regress-1029642.js Loading commit data...
regress-1030103.js Loading commit data...
regress-10309.js Loading commit data...
regress-1032753.js Loading commit data...
regress-1033948.js Loading commit data...
regress-1045225.js Loading commit data...
regress-1045737.js Loading commit data...
regress-1046472.js Loading commit data...
regress-1048241.js Loading commit data...
regress-1051912.js Loading commit data...
regress-1054466.js Loading commit data...
regress-1065599.js Loading commit data...
regress-1065635.js Loading commit data...
regress-1065852.js Loading commit data...
regress-1067621.js Loading commit data...
regress-1070078.js Loading commit data...
regress-10702.js Loading commit data...
regress-1073553.js Loading commit data...
regress-1074586-b.js Loading commit data...
regress-1074586.js Loading commit data...
regress-1075953.js Loading commit data...
regress-1079449.js Loading commit data...
regress-1080902.js Loading commit data...
regress-1081030.js Loading commit data...
regress-10831.js Loading commit data...
regress-1084151.js Loading commit data...
regress-1101304.js Loading commit data...
regress-1111522.js Loading commit data...
regress-1112124.js Loading commit data...
regress-1114005.js Loading commit data...
regress-1116019.js Loading commit data...
regress-1125951.js Loading commit data...
regress-5531.js Loading commit data...
regress-5800.js Loading commit data...
regress-5860.js Loading commit data...
regress-5884.js Loading commit data...
regress-6054.js Loading commit data...
regress-6164.js Loading commit data...
regress-643595.js Loading commit data...
regress-644682.js Loading commit data...
regress-647649.js Loading commit data...
regress-648079.js Loading commit data...
regress-651961.js Loading commit data...
regress-654377.js Loading commit data...
regress-663994.js Loading commit data...
regress-666741.js Loading commit data...
regress-667745.js Loading commit data...
regress-670683.js Loading commit data...
regress-674447.js Loading commit data...
regress-680938.js Loading commit data...
regress-684858.js Loading commit data...
regress-688876.js Loading commit data...
regress-689450.js Loading commit data...
regress-6931.js Loading commit data...
regress-694433.js Loading commit data...
regress-698587.js Loading commit data...
regress-699485.js Loading commit data...
regress-702460.js Loading commit data...
regress-702839.js Loading commit data...
regress-7033.js Loading commit data...
regress-7035.js Loading commit data...
regress-703568.js Loading commit data...
regress-708714.js Loading commit data...
regress-709684.js Loading commit data...
regress-710844.js Loading commit data...
regress-711203.js Loading commit data...
regress-712569.js Loading commit data...
regress-717056.js Loading commit data...
regress-717194.js Loading commit data...
regress-722445.js Loading commit data...
regress-724846.js Loading commit data...
regress-724851.js Loading commit data...
regress-724972.js Loading commit data...
regress-727219.js Loading commit data...
regress-727222.js Loading commit data...
regress-727560.js Loading commit data...
regress-729991.js Loading commit data...
regress-731351.js Loading commit data...
regress-734108.js Loading commit data...
regress-734246.js Loading commit data...
regress-734345.js Loading commit data...
regress-7353.js Loading commit data...
regress-7364.js Loading commit data...
regress-736584.js Loading commit data...
regress-7366.js Loading commit data...
regress-737069.js Loading commit data...
regress-739768.js Loading commit data...
regress-7422.js Loading commit data...
regress-7499.js Loading commit data...
regress-7508.js Loading commit data...
regress-752423.js Loading commit data...
regress-753496.js Loading commit data...
regress-7565.js Loading commit data...
regress-757217.js Loading commit data...
regress-7579.js Loading commit data...
regress-7582.js Loading commit data...
regress-763439.js Loading commit data...
regress-763697.js Loading commit data...
regress-769637.js Loading commit data...
regress-769846.js Loading commit data...
regress-775366.js Loading commit data...
regress-775710.js Loading commit data...
regress-776677.js Loading commit data...
regress-7785.js Loading commit data...
regress-782280.js Loading commit data...
regress-784050.js Loading commit data...
regress-7914.js Loading commit data...
regress-791810.js Loading commit data...
regress-793551.js Loading commit data...
regress-797846.js Loading commit data...
regress-799952.js Loading commit data...
regress-800756.js Loading commit data...
regress-801785.js Loading commit data...
regress-801850.js Loading commit data...
regress-802244.js Loading commit data...
regress-803427.js Loading commit data...
regress-803788.js Loading commit data...
regress-8059.js Loading commit data...
regress-808012.js Loading commit data...
regress-808848.js Loading commit data...
regress-808980.js Loading commit data...
regress-8094.js Loading commit data...
regress-8095.js Loading commit data...
regress-810973.js Loading commit data...
regress-810973b.js Loading commit data...
regress-812005.js Loading commit data...
regress-816226.js Loading commit data...
regress-817380.js Loading commit data...
regress-819869.js Loading commit data...
regress-820802.js Loading commit data...
regress-824681.js Loading commit data...
regress-825087a.js Loading commit data...
regress-825087b.js Loading commit data...
regress-827806.js Loading commit data...
regress-834619.js Loading commit data...
regress-834693.js Loading commit data...
regress-836141.js Loading commit data...
regress-837417.js Loading commit data...
regress-840757.js Loading commit data...
regress-842501.js Loading commit data...
regress-843563.js Loading commit data...
regress-8505.js Loading commit data...
regress-8533.js Loading commit data...
regress-853453.js Loading commit data...
regress-854011.js Loading commit data...
regress-854050.js Loading commit data...
regress-864509.js Loading commit data...
regress-873600.js Loading commit data...
regress-875556.js Loading commit data...
regress-8846.js Loading commit data...
regress-8896.js Loading commit data...
regress-894307.js Loading commit data...
regress-894374.js Loading commit data...
regress-898932.js Loading commit data...
regress-9017.js Loading commit data...
regress-905815.js Loading commit data...
regress-910824.js Loading commit data...
regress-913804.js Loading commit data...
regress-916869.js Loading commit data...
regress-917412.js Loading commit data...
regress-917588.js Loading commit data...
regress-917588b.js Loading commit data...
regress-918149.js Loading commit data...
regress-918284.js Loading commit data...
regress-918917.js Loading commit data...
regress-919308.js Loading commit data...
regress-919533.js Loading commit data...
regress-922432.js Loading commit data...
regress-922670.js Loading commit data...
regress-922933.js Loading commit data...
regress-924843.js Loading commit data...
regress-924905.js Loading commit data...
regress-925671.js Loading commit data...
regress-935138.js Loading commit data...
regress-940296.js Loading commit data...
regress-9425.js Loading commit data...
regress-9447.js Loading commit data...
regress-946350.js Loading commit data...
regress-948228.js Loading commit data...
regress-952342.js Loading commit data...
regress-956771.js Loading commit data...
regress-956771b.js Loading commit data...
regress-957405.js Loading commit data...
regress-961129.js Loading commit data...
regress-964607.js Loading commit data...
regress-968078.js Loading commit data...
regress-9759.js Loading commit data...
regress-980007.js Loading commit data...
regress-985154.js Loading commit data...
regress-crbug-1002388.js Loading commit data...
regress-crbug-1006631.js Loading commit data...
regress-crbug-1057094.js Loading commit data...
regress-ubsan.js Loading commit data...