• Mostyn Bramley-Moore's avatar
    [jumbo] fix arm64 builds · 46000a12
    Mostyn Bramley-Moore authored
    Previously instructions-arm64.h was alternatively defining or declaring
    some constants based on whether or not ARM64_DEFINE_FP_STATICS was defined,
    and it was assumed that exactly one file would include this header with
    the macro defined.
    
    In jumbo builds, the header guards in instructions-arm64.h meant that the
    resulting state of the header file would be whichever of the two cases
    that appeared first in the compilation unit.  This would cause multiple
    definitions in some cases and no definitions in some other cases (or if
    you were really lucky, it would work out ok).
    
    Let's move these constants to a separate source file temporarily, to be
    excluded from jumbo compilation units.  This code should eventually be
    replaced with a cleaner solution.
    
    Bug: chromium:746958
    Change-Id: I7edb1821ef408afd50c6b236d63d3c07f955b58f
    Reviewed-on: https://chromium-review.googlesource.com/663898
    Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48003}
    46000a12
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...