• Jakob Gruber's avatar
    Reland "[code] Move the unwinding info into metadata area" · 82f6863a
    Jakob Gruber authored
    This is a reland of c5379162
    
    The reland fixes Code::clear_padding to correctly clear trailing
    padding.
    
    Original change's description:
    > [code] Move the unwinding info into metadata area
    >
    > Semantically, the unwinding info is a variable-size metadata table
    > with untagged (i.e. no relocation needed) contents, packed inside Code
    > objects. This is just like other metadata tables (safepoint table,
    > handler table, constant pool, code comments); but for historical
    > reasons it's been treated differently so far. Unlike these other
    > tables, the unwinding info was located *after* InstructionEnd, and its
    > size was written to the first 8 bytes after InstructionEnd.
    >
    > This CL makes unwinding info handling more consistent with other
    > metadata tables by writing its offset into a dedicated
    > kUnwindingInfoOffsetOffset header slot, and by moving the actual data
    > inside the [InstructionStart,InstructionEnd[ area. In follow-up CLs,
    > this area will be split into dedicated instruction- and metadata
    > areas.
    >
    > A picture is worth 1000 words, before:
    >
    >  +--------------------------+  <-- raw_instruction_start()
    >  |       instructions       |
    >  |           ...            |
    >  +--------------------------+
    >  |     embedded metadata    |  <-- safepoint_table_offset()
    >  |           ...            |  <-- handler_table_offset()
    >  |                          |  <-- constant_pool_offset()
    >  |                          |  <-- code_comments_offset()
    >  |    padding to the next   |
    >  |  8-byte aligned address  |
    >  +--------------------------+  <-- raw_instruction_end()
    >  |   [unwinding_info_size]  |
    >  |        as uint64_t       |
    >  +--------------------------+  <-- unwinding_info_start()
    >  |       unwinding info     |
    >  |            ...           |
    >  +--------------------------+  <-- unwinding_info_end()
    >
    > After:
    >
    >  +--------------------------+  <-- raw_instruction_start()
    >  |       instructions       |
    >  |           ...            |
    >  +--------------------------+
    >  |     embedded metadata    |  <-- safepoint_table_offset()
    >  |           ...            |  <-- handler_table_offset()
    >  |                          |  <-- constant_pool_offset()
    >  |                          |  <-- code_comments_offset()
    >  |                          |  <-- unwinding_info_offset()
    >  |                          |
    >  +--------------------------+  <-- raw_instruction_end()
    >
    > Bug: v8:11036
    > Change-Id: I649708821acc5365186ca2c9cff2669fc3e91fd3
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2484795
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70640}
    
    Cq-Include-Trybots: luci.v8.try:v8_linux64_msan_rel_ng
    Tbr: leszeks@chromium.org
    Bug: v8:11036
    Change-Id: I2ea056fe2a53217e0b5ae25661b92f5ddec6fca5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2485501
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70645}
    82f6863a
Name
Last commit
Last update
..
compiler Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
parsing Loading commit data...
torque Loading commit data...
wasm Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
assembler-helper-arm.cc Loading commit data...
assembler-helper-arm.h Loading commit data...
cctest-utils.h Loading commit data...
cctest.cc Loading commit data...
cctest.h Loading commit data...
cctest.status Loading commit data...
collector.h Loading commit data...
disasm-regex-helper.cc Loading commit data...
disasm-regex-helper.h Loading commit data...
expression-type-collector-macros.h Loading commit data...
gay-fixed.cc Loading commit data...
gay-fixed.h Loading commit data...
gay-precision.cc Loading commit data...
gay-precision.h Loading commit data...
gay-shortest.cc Loading commit data...
gay-shortest.h Loading commit data...
manually-externalized-buffer.h Loading commit data...
print-extension.cc Loading commit data...
print-extension.h Loading commit data...
profiler-extension.cc Loading commit data...
profiler-extension.h Loading commit data...
scope-test-helper.h Loading commit data...
setup-isolate-for-tests.cc Loading commit data...
setup-isolate-for-tests.h Loading commit data...
test-access-checks.cc Loading commit data...
test-accessor-assembler.cc Loading commit data...
test-accessors.cc Loading commit data...
test-allocation.cc Loading commit data...
test-api-accessors.cc Loading commit data...
test-api-array-buffer.cc Loading commit data...
test-api-icu.cc Loading commit data...
test-api-interceptors.cc Loading commit data...
test-api-stack-traces.cc Loading commit data...
test-api-typed-array.cc Loading commit data...
test-api-wasm.cc Loading commit data...
test-api.cc Loading commit data...
test-api.h Loading commit data...
test-array-list.cc Loading commit data...
test-assembler-arm.cc Loading commit data...
test-assembler-arm64.cc Loading commit data...
test-assembler-ia32.cc Loading commit data...
test-assembler-mips.cc Loading commit data...
test-assembler-mips64.cc Loading commit data...
test-assembler-ppc.cc Loading commit data...
test-assembler-s390.cc Loading commit data...
test-assembler-x64.cc Loading commit data...
test-atomicops.cc Loading commit data...
test-backing-store.cc Loading commit data...
test-bignum-dtoa.cc Loading commit data...
test-bignum.cc Loading commit data...
test-bit-vector.cc Loading commit data...
test-circular-queue.cc Loading commit data...
test-code-layout.cc Loading commit data...
test-code-pages.cc Loading commit data...
test-code-stub-assembler.cc Loading commit data...
test-compiler.cc Loading commit data...
test-concurrent-descriptor-array.cc Loading commit data...
test-concurrent-prototype.cc Loading commit data...
test-concurrent-script-context-table.cc Loading commit data...
test-concurrent-transition-array.cc Loading commit data...
test-constantpool.cc Loading commit data...
test-conversions.cc Loading commit data...
test-cpu-profiler.cc Loading commit data...
test-date.cc Loading commit data...
test-debug-helper.cc Loading commit data...
test-debug.cc Loading commit data...
test-decls.cc Loading commit data...
test-deoptimization.cc Loading commit data...
test-descriptor-array.cc Loading commit data...
test-dictionary.cc Loading commit data...
test-disasm-arm.cc Loading commit data...
test-disasm-arm64.cc Loading commit data...
test-disasm-ia32.cc Loading commit data...
test-disasm-mips.cc Loading commit data...
test-disasm-mips64.cc Loading commit data...
test-disasm-ppc.cc Loading commit data...
test-disasm-s390.cc Loading commit data...
test-disasm-x64.cc Loading commit data...
test-diy-fp.cc Loading commit data...
test-double.cc Loading commit data...
test-dtoa.cc Loading commit data...
test-elements-kind.cc Loading commit data...
test-factory.cc Loading commit data...
test-fast-dtoa.cc Loading commit data...
test-feedback-vector.cc Loading commit data...
test-feedback-vector.h Loading commit data...
test-field-type-tracking.cc Loading commit data...
test-fixed-dtoa.cc Loading commit data...
test-flags.cc Loading commit data...
test-func-name-inference.cc Loading commit data...
test-fuzz-arm64.cc Loading commit data...
test-global-handles.cc Loading commit data...
test-global-object.cc Loading commit data...
test-hashcode.cc Loading commit data...
test-hashmap.cc Loading commit data...
test-heap-profiler.cc Loading commit data...
test-icache.cc Loading commit data...
test-identity-map.cc Loading commit data...
test-inobject-slack-tracking.cc Loading commit data...
test-inspector.cc Loading commit data...
test-intl.cc Loading commit data...
test-javascript-arm64.cc Loading commit data...
test-js-arm64-variables.cc Loading commit data...
test-js-weak-refs.cc Loading commit data...
test-liveedit.cc Loading commit data...
test-local-handles.cc Loading commit data...
test-lockers.cc Loading commit data...
test-log-stack-tracer.cc Loading commit data...
test-log.cc Loading commit data...
test-macro-assembler-arm.cc Loading commit data...
test-macro-assembler-arm64.cc Loading commit data...
test-macro-assembler-mips.cc Loading commit data...
test-macro-assembler-mips64.cc Loading commit data...
test-macro-assembler-x64.cc Loading commit data...
test-managed.cc Loading commit data...
test-mementos.cc Loading commit data...
test-modules.cc Loading commit data...
test-object.cc Loading commit data...
test-orderedhashtable.cc Loading commit data...
test-parsing.cc Loading commit data...
test-persistent-handles.cc Loading commit data...
test-platform.cc Loading commit data...
test-pointer-auth-arm64.cc Loading commit data...
test-poison-disasm-arm.cc Loading commit data...
test-poison-disasm-arm64.cc Loading commit data...
test-profile-generator.cc Loading commit data...
test-random-number-generator.cc Loading commit data...
test-regexp.cc Loading commit data...
test-representation.cc Loading commit data...
test-roots.cc Loading commit data...
test-sampler-api.cc Loading commit data...
test-serialize.cc Loading commit data...
test-smi-lexicographic-compare.cc Loading commit data...
test-stack-unwinding-win64.cc Loading commit data...
test-strings.cc Loading commit data...
test-strtod.cc Loading commit data...
test-symbols.cc Loading commit data...
test-sync-primitives-arm.cc Loading commit data...
test-sync-primitives-arm64.cc Loading commit data...
test-thread-termination.cc Loading commit data...
test-threads.cc Loading commit data...
test-trace-event.cc Loading commit data...
test-traced-value.cc Loading commit data...
test-transitions.cc Loading commit data...
test-transitions.h Loading commit data...
test-typedarrays.cc Loading commit data...
test-types.cc Loading commit data...
test-unboxed-doubles.cc Loading commit data...
test-unscopables-hidden-prototype.cc Loading commit data...
test-unwinder-code-pages.cc Loading commit data...
test-usecounters.cc Loading commit data...
test-utils-arm64.cc Loading commit data...
test-utils-arm64.h Loading commit data...
test-utils.cc Loading commit data...
test-v8windbg.cc Loading commit data...
test-verifiers.cc Loading commit data...
test-version.cc Loading commit data...
test-weakmaps.cc Loading commit data...
test-weaksets.cc Loading commit data...
testcfg.py Loading commit data...
trace-extension.cc Loading commit data...
trace-extension.h Loading commit data...
unicode-helpers.cc Loading commit data...
unicode-helpers.h Loading commit data...