• Iain Ireland's avatar
    [regexp] Hoist LoadCurrentCharacterImpl · 4536bb2e
    Iain Ireland authored
    LoadCurrentCharacterImpl is implemented once in each of the eight
    regexp-macro-assembler-<arch>.cc files. Aside from small differences
    in comment wording, those eight implementations are identical. The
    architecture-specific code for LoadCurrentCharacter is all in
    LoadCurrentCharacterUnchecked.
    
    This patch hoists the definition of LoadCurrentCharacterImpl into
    NativeRegExpMacroAssembler and turns LoadCurrentCharacterUnchecked
    into a virtual function.
    
    Note: The arm64 version of LoadCurrentCharacterImpl contained the
    following six-year-old comment, which I don't think is worth
    preserving:
    
    // TODO(pielan): Make sure long strings are caught before this, and
    // not just asserted in debug mode.
    
    R=jgruber@chromium.org
    
    Bug: v8:10406
    Change-Id: Ic81283ad3b618d6b06f4206fb77d30de617dccb7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140003
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67260}
    4536bb2e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...