• Jakob Kummerow's avatar
    [DataView] Throw TypeError when buffer is detached · 4534e8cc
    Jakob Kummerow authored
    Per spec, accesses to a DataView object must throw a TypeError if
    the underlying ArrayBuffer has been detached/neutered. Since that
    implies a length of 0, we used to detect this as an out-of-bounds
    access and throw a RangeError. Adding a separate check for buffer
    detachedness lets us distinguish both cases properly.
    
    Bug: v8:4895
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: I1c1d4145dcd77dfb69f61062e14a6e8e538d45eb
    Reviewed-on: https://chromium-review.googlesource.com/947585Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51712}
    4534e8cc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...