• Maya Lekova's avatar
    [turbofan] Introduce a CheckStringAdd node instead of cons string lowering · 6a7872b7
    Maya Lekova authored
    The new node is introduced for literal string addition and calling
    String.prototype.concat in the typed lowering phase. It later might get optimized
    away during redundancy elimination, keeping the performance of already existing
    benchmarks with string addition. In case the operation is about to throw
    (due to too long string being constructed) we just deoptimize, reusing
    the interpreter logic for creating the error.
    
    Modify relevant mjsunit and unit tests for string concatenation.
    
    Bug: v8:7902
    Change-Id: Ie97d39534df4480fa8d4fe3ba276d02ed5e750e3
    Reviewed-on: https://chromium-review.googlesource.com/1193342
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55482}
    6a7872b7
Name
Last commit
Last update
..
Array Loading commit data...
ArrayLiteralInitialSpreadLargeHoley Loading commit data...
ArrayLiteralInitialSpreadLargePacked Loading commit data...
ArrayLiteralInitialSpreadSmallHoley Loading commit data...
ArrayLiteralInitialSpreadSmallPacked Loading commit data...
ArrayLiteralSpread Loading commit data...
ArraySort Loading commit data...
AsyncAwait Loading commit data...
BytecodeHandlers Loading commit data...
Classes Loading commit data...
Closures Loading commit data...
Collections Loading commit data...
DataView Loading commit data...
Exceptions Loading commit data...
ExpressionDepth Loading commit data...
ForLoops Loading commit data...
Generators Loading commit data...
Inspector Loading commit data...
Iterators Loading commit data...
Keys Loading commit data...
ManyClosures Loading commit data...
Modules Loading commit data...
Numbers Loading commit data...
Object Loading commit data...
ObjectLiteralSpread Loading commit data...
Parsing Loading commit data...
PropertyQueries Loading commit data...
Proxies Loading commit data...
RegExp Loading commit data...
RestParameters Loading commit data...
Scope Loading commit data...
SixSpeed Loading commit data...
SpreadCalls Loading commit data...
SpreadCallsGeneral Loading commit data...
StringIterators Loading commit data...
Strings Loading commit data...
Templates Loading commit data...
TurboFan Loading commit data...
TypedArrays Loading commit data...
JSTests.json Loading commit data...
OWNERS Loading commit data...
RegExp.json Loading commit data...
SixSpeed.json Loading commit data...
base.js Loading commit data...