• Michael Lippautz's avatar
    cppgc: Fix re-tracing weak containers · ce83994e
    Michael Lippautz authored
    Weak containers are re-traced during conservative stack scanning to
    strongify their contents. This runs in parallel with concurrent
    marking that could find new weak containers.
    
    The CL fixes two issues:
    - The concurrent marker could find a weak container and mark it but
      would only add it to the set of weak containers afterwards. We need to
      reverse this (using a lock) to make sure that the main thread sees the
      marked weak container.
    - The DCHECK for containment needs to be concurrency aware.
    
    Bug: chromium:1349298
    Change-Id: I1ec31db62647f7f1c19e9cc60976e09946551333
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807593Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82170}
    ce83994e
Name
Last commit
Last update
..
DEPS Loading commit data...
allocation.cc Loading commit data...
caged-heap-local-data.cc Loading commit data...
caged-heap.cc Loading commit data...
caged-heap.h Loading commit data...
compaction-worklists.cc Loading commit data...
compaction-worklists.h Loading commit data...
compactor.cc Loading commit data...
compactor.h Loading commit data...
concurrent-marker.cc Loading commit data...
concurrent-marker.h Loading commit data...
explicit-management.cc Loading commit data...
free-list.cc Loading commit data...
free-list.h Loading commit data...
garbage-collector.h Loading commit data...
gc-info-table.cc Loading commit data...
gc-info-table.h Loading commit data...
gc-info.cc Loading commit data...
gc-invoker.cc Loading commit data...
gc-invoker.h Loading commit data...
globals.h Loading commit data...
heap-base.cc Loading commit data...
heap-base.h Loading commit data...
heap-consistency.cc Loading commit data...
heap-growing.cc Loading commit data...
heap-growing.h Loading commit data...
heap-object-header.cc Loading commit data...
heap-object-header.h Loading commit data...
heap-page.cc Loading commit data...
heap-page.h Loading commit data...
heap-space.cc Loading commit data...
heap-space.h Loading commit data...
heap-state.cc Loading commit data...
heap-statistics-collector.cc Loading commit data...
heap-statistics-collector.h Loading commit data...
heap-visitor.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-schedule.cc Loading commit data...
incremental-marking-schedule.h Loading commit data...
liveness-broker.cc Loading commit data...
liveness-broker.h Loading commit data...
logging.cc Loading commit data...
marker.cc Loading commit data...
marker.h Loading commit data...
marking-state.cc Loading commit data...
marking-state.h Loading commit data...
marking-verifier.cc Loading commit data...
marking-verifier.h Loading commit data...
marking-visitor.cc Loading commit data...
marking-visitor.h Loading commit data...
marking-worklists.cc Loading commit data...
marking-worklists.h Loading commit data...
member-storage.cc Loading commit data...
member-storage.h Loading commit data...
memory.cc Loading commit data...
memory.h Loading commit data...
metric-recorder.h Loading commit data...
name-trait.cc Loading commit data...
object-allocator.cc Loading commit data...
object-allocator.h Loading commit data...
object-poisoner.h Loading commit data...
object-size-trait.cc Loading commit data...
object-start-bitmap.h Loading commit data...
object-view.h Loading commit data...
page-memory.cc Loading commit data...
page-memory.h Loading commit data...
persistent-node.cc Loading commit data...
platform.cc Loading commit data...
platform.h Loading commit data...
pointer-policies.cc Loading commit data...
prefinalizer-handler.cc Loading commit data...
prefinalizer-handler.h Loading commit data...
process-heap-statistics.cc Loading commit data...
process-heap-statistics.h Loading commit data...
process-heap.cc Loading commit data...
process-heap.h Loading commit data...
raw-heap.cc Loading commit data...
raw-heap.h Loading commit data...
remembered-set.cc Loading commit data...
remembered-set.h Loading commit data...
source-location.cc Loading commit data...
stats-collector.cc Loading commit data...
stats-collector.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
task-handle.h Loading commit data...
testing.cc Loading commit data...
trace-event.h Loading commit data...
trace-trait.cc Loading commit data...
unmarker.h Loading commit data...
virtual-memory.cc Loading commit data...
virtual-memory.h Loading commit data...
visitor.cc Loading commit data...
visitor.h Loading commit data...
write-barrier.cc Loading commit data...
write-barrier.h Loading commit data...