• Michael Achenbach's avatar
    Revert "[wasm] The name of a custom section can cause a validation error" · 43accc8b
    Michael Achenbach authored
    This reverts commit 03d5a7ba.
    
    Reason for revert: Needs rebaseline:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/3243
    
    Original change's description:
    > [wasm] The name of a custom section can cause a validation error
    > 
    > The WebAssembly spec defines that the name of a custom section can cause
    > a validation error. The streaming decoder, however, used a separate
    > Decoder object to decode the name, and thereby avoided a validation
    > error. With this CL the streaming decoder uses the main decoder to
    > decode the name of the custom section.
    > 
    > In addition this CL removes the test mjsunit/regress/wasm/regress-789952.
    > This test defined an invalid WebAssembly module and expected it to
    > compile. As it is a regression test, it makes no sense to fix the test.
    > The module is invalid because it defines the length of the custom section
    > to be '0', so there are no bytes in the custom section for its name.
    > 
    > R=​clemensb@chromium.org
    > CC=​thibaudm@chromium.org
    > 
    > Bug: v8:10126
    > Change-Id: I8cfc77c9a5916570d5362d5922e0179a29774da8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2041446
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66348}
    
    TBR=ahaas@chromium.org,clemensb@chromium.org
    
    Change-Id: I5a7ea265ce47b9e685a5056bb83db6dc58f774a9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10126
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2065168Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66356}
    43accc8b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...