• Jakob Gruber's avatar
    Don't attempt to create source positions for unfinalized scripts · 4371d88d
    Jakob Gruber authored
    For streaming compilation, scripts don't have a source string attached
    until finalization, but the Script and SharedFunctionInfo objects are
    already on the heap and may be picked up by heap walks.
    
    This happens e.g. in CollectSourcePositionsForAllBytecodeArrays, where
    we then try to reparse and recompile the SFI. This is invalid, since
    the source string is not yet set.
    
    Avoid this by checking for the empty source string (and leaving a TODO
    for a nicer future solution).
    
    Bug: v8:12051
    Change-Id: Ib4f40cd218151120e5aff8558dd5df5c8834412e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071403
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76104}
    4371d88d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...