-
Peter Marshall authored
This reverts commit c92a1dda. Reason for revert: Breaks arm sim: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim/15207 Original change's description: > [cpu-profiler] Fix a bug which caused a pure virtual function call > > We need to remove each Sampler from the SamplerManager before we call > the Sampler destructor. This is because the signal handler can interrupt > the destructor, and call DoSampler(), which calls sampler->SampleStack() > on the sampler being destructed, causing general unhappiness and > "Pure virtual function called!" crashes. > > Bug: v8:8346, v8:5193 > Change-Id: Iaa595a196eab33fb1af31584e9a68fd1ce0a18f6 > Reviewed-on: https://chromium-review.googlesource.com/c/1293949 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56882} TBR=alph@chromium.org,yangguo@chromium.org,petermarshall@chromium.org Change-Id: I517e07d75045f6253e7f12714304fba77959fbc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8346, v8:5193 Reviewed-on: https://chromium-review.googlesource.com/c/1296472Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56889}
1bcc69d7
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
DEPS | ||
sampler.cc | ||
sampler.h |