• Sigurd Schneider's avatar
    Revert "[sfi] Remove SFI function literal id field" · 58578584
    Sigurd Schneider authored
    This reverts commit 1d4a1172.
    
    Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21989
    
    Original change's description:
    > [sfi] Remove SFI function literal id field
    > 
    > SharedFunctionInfos store their original function literal's id. This is
    > also their index in the Script's SFI list.
    > 
    > The function literal id is only needed for lazy compilation and live edit,
    > and access only has to be fast in the former. So, we can move the SFI
    > function literal id field to UncompiledData, and if patching with live
    > edit, or discarding compiled code, we can perform a slower linear search
    > through the Script's SFI list.
    > 
    > This is a reland of
    > https://chromium-review.googlesource.com/c/v8/v8/+/1082480
    > but caching the literal id on UncompiledData rather than always linearly
    > searching the SFI list. Also, removes the unused runtime-liveedit.cc file
    > instead of fixing it to support this change.
    > 
    > Bug: chromium:818642
    > Change-Id: I977bcca0dc72903ca476a7079d156cc8bbe88fde
    > Reviewed-on: https://chromium-review.googlesource.com/1128854
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#54464}
    
    TBR=ulan@chromium.org,marja@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,cbruni@chromium.org,leszeks@chromium.org,verwaest@chromium.org
    
    Change-Id: Icee5ee3ab7688b93e2963f91debed65a58164534
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:818642
    Reviewed-on: https://chromium-review.googlesource.com/1138276Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54466}
    58578584
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
debug-coverage.cc Loading commit data...
debug-coverage.h Loading commit data...
debug-evaluate.cc Loading commit data...
debug-evaluate.h Loading commit data...
debug-frames.cc Loading commit data...
debug-frames.h Loading commit data...
debug-interface.h Loading commit data...
debug-scope-iterator.cc Loading commit data...
debug-scope-iterator.h Loading commit data...
debug-scopes.cc Loading commit data...
debug-scopes.h Loading commit data...
debug-stack-trace-iterator.cc Loading commit data...
debug-stack-trace-iterator.h Loading commit data...
debug-type-profile.cc Loading commit data...
debug-type-profile.h Loading commit data...
debug.cc Loading commit data...
debug.h Loading commit data...
interface-types.h Loading commit data...
liveedit.cc Loading commit data...
liveedit.h Loading commit data...