• Dominik Inführ's avatar
    [heap] Combine write barrier flag checks · 407218d6
    Dominik Inführ authored
    Adding the shared heap write barrier caused regressions on some
    benchmarks. Presumably this is because the compiler can't merge the
    fast paths of the generational and shared heap write barrier.
    
    This CL therefore introduces a CombinedHeapBarrier that manually
    unifies the fast path for the marking, generational and shared heap
    write barrier. This should make the barrier easier to optimize for
    the compiler. In particular it should help to ensure that page flags
    don't need to be loaded multiple times in a single full write barrier.
    
    Bug: chromium:1326446, v8:11708
    Change-Id: Iacd487f1263491cf4c05f25e004233a52b7c45a6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644964Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80656}
    407218d6
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...