• Clemens Backes's avatar
    Reland "Reland: [wasm] Check correctness of thread-local write protection" · 3fd8025d
    Clemens Backes authored
    This is a reland of 1c0cca0f. It is
    modified now to use V8_HAS_PTHREAD_JIT_WRITE_PROTECT and is rebased on
    https://crrev.com/c/3085271 which fixes the definition of that macro.
    
    Original change's description:
    > Reland: [wasm] Check correctness of thread-local write protection
    >
    > The fix landed as a separate CL: https://crrev.com/c/3081522
    > This is an unmodified reland.
    >
    > Original description:
    > We make an undocumented assumption in {CodeSpaceWriteScope} that a
    > single thread will only work on one module at a time. If this is
    > violated, the thread-local {code_space_write_nesting_level_} would
    > prevent the second module from being switched to writable.
    >
    > This CL adds a second thread local (in debug only) to check that if
    > there is already a {CodeSpaceWriteScope} open that it contains the same
    > {NativeModule} as any nested scope.
    >
    > R=jkummerow@chromium.org
    >
    > Bug: v8:11974
    > Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
    > Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
    > Change-Id: Id827b6ca472f695e4500584349aba159aa07eed1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3080578
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76177}
    
    Bug: v8:11974
    Change-Id: Iffc510e85c8c56f26bfa88115ed3a8bdd33ef422
    Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3085269Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76235}
    3fd8025d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...