• Seth Brenith's avatar
    Revert "Move branch inversion on ==0 into platform-agnostic reducer" · 252acd7f
    Seth Brenith authored
    This reverts commit 0c72c719.
    
    Reason for revert: Wasm code size increase because not all pipelines use CommonOperatorReducer
    
    Original change's description:
    > Move branch inversion on ==0 into platform-agnostic reducer
    > 
    > This change is based on a discussion from
    > https://crrev.com/c/v8/v8/+/2053769/4/src/compiler/machine-operator-reducer.cc#1696
    > wherein Tobias suggested moving the folding away of ==0 operations out
    > of the platform-specific instruction selectors and into the
    > MachineOperatorReducer. I noticed that CommonOperatorReducer already
    > handles some very similar cases, so I have tried putting the ==0 folding
    > into CommonOperatorReducer instead. I'm happy to move it into
    > MachineOperatorReducer if that's better; I still don't have a very good
    > understanding of how roles are separated among reducers.
    > 
    > Change-Id: Ia0285bd9fafeef29d87cc88654bd6d355d467e8f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076498
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66688}
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:1061767
    Change-Id: Id1fdfb38357eb514d92ed3be0a683f077202faa4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2117789
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66862}
    252acd7f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...