-
machenbach authored
Revert of [es7] refactor and fix Object.values() / Object.entries() (patchset #6 id:100001 of https://codereview.chromium.org/1637753004/ ) Reason for revert: [Sheriff] Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/1642 Original issue's description: > [es7] refactor and fix Object.values() / Object.entries() > > Previously, Object.values() and Object.entries() were piggy-backing on > Object.keys(). This meant that they would pre-filter non-enumerable properties, > violating the runtime behaviour of the methods. Unfortunately, this does not > match the current proposal text. > > Also incorporates several tests verifying this behaviour based on tests included > in the ChakraCore implementation. > > BUG=v8:4663 > LOG=N > R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org > > Committed: https://crrev.com/5c5ccd9d7f8693990d1a9eb26ba3a94f376dcf0b > Cr-Commit-Position: refs/heads/master@{#33782} TBR=littledan@chromium.org,adamk@chromium.org,cbruni@chromium.org,rossberg@chromium.org,caitpotter88@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4663 Review URL: https://codereview.chromium.org/1675663002 Cr-Commit-Position: refs/heads/master@{#33787}
bdfcc613