• Clemens Backes's avatar
    [assembler] Remove the "no condition" · 738f4b69
    Clemens Backes authored
    The no_condition / kNoCondition not only has the flaw that it's a
    special case which represents an illegal / nonexisting condition, and
    thus needs special handling in all methods which get a condition as
    input (this check is often missing), it is also weird in that every
    negative condition value must be considered a "no condition".
    
    It turns out that this "no condition" is rarely used, and can easily be
    avoided by duplicating methods, or storing a {base::Optional<Condition>}
    instead (not needed anywhere yet).
    
    This is a follow-up to https://crrev.com/c/3629553.
    
    R=tebbi@chromium.org, pthier@chromium.org
    
    Bug: v8:12425
    Change-Id: Id2270b1660fcb0aff0a8460961b57068ed1c3c73
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632102Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarPatrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80397}
    738f4b69
Name
Last commit
Last update
..
assembler-ia32-inl.h Loading commit data...
assembler-ia32.cc Loading commit data...
assembler-ia32.h Loading commit data...
constants-ia32.h Loading commit data...
cpu-ia32.cc Loading commit data...
fma-instr.h Loading commit data...
interface-descriptors-ia32-inl.h Loading commit data...
macro-assembler-ia32.cc Loading commit data...
macro-assembler-ia32.h Loading commit data...
register-ia32.h Loading commit data...
reglist-ia32.h Loading commit data...
sse-instr.h Loading commit data...