• Adam Klein's avatar
    Reland "[parser] Remove pretenuring of closures assigned to properties" · 3d7ad2e7
    Adam Klein authored
    The memory gains were significant, so despite the bluebird-doxbee
    regression, we think it's better to have this patch than not.
    See the attached Chromium bug for more discussion.
    
    This is a reland of 20e346bd.
    
    Original change's description:
    > [parser] Remove pretenuring of closures assigned to properties
    >
    > This pretenuring was added in https://codereview.chromium.org/5220007,
    > back when it was necessary in order to allow use of the closure
    > as a "constant function" property. This should no longer be the case,
    > and the pretenuring causes some unfortunate downstream effects.
    >
    > This patch removes the parser's setting of this bit. If it doesn't
    > cause regressions on the perf bots, followup CLs will remove the
    > rest of the support for this feature.
    >
    > Bug: v8:7442
    > Change-Id: I27c43dd4293ce5de921be6c78571e712778d138a
    > Reviewed-on: https://chromium-review.googlesource.com/914610
    > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    > Commit-Queue: Adam Klein <adamk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51254}
    
    Bug: v8:7442, chromium:814182
    Change-Id: I228c59dccef3844803f115749e72ae6c5f286eda
    Reviewed-on: https://chromium-review.googlesource.com/938241Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51668}
    3d7ad2e7
Name
Last commit
Last update
..
OWNERS Loading commit data...
duplicate-finder.h Loading commit data...
expression-classifier.h Loading commit data...
expression-scope-reparenter.cc Loading commit data...
expression-scope-reparenter.h Loading commit data...
func-name-inferrer.cc Loading commit data...
func-name-inferrer.h Loading commit data...
parse-info.cc Loading commit data...
parse-info.h Loading commit data...
parser-base.h Loading commit data...
parser.cc Loading commit data...
parser.h Loading commit data...
parsing.cc Loading commit data...
parsing.h Loading commit data...
pattern-rewriter.cc Loading commit data...
preparse-data.cc Loading commit data...
preparse-data.h Loading commit data...
preparsed-scope-data.cc Loading commit data...
preparsed-scope-data.h Loading commit data...
preparser.cc Loading commit data...
preparser.h Loading commit data...
rewriter.cc Loading commit data...
rewriter.h Loading commit data...
scanner-character-streams.cc Loading commit data...
scanner-character-streams.h Loading commit data...
scanner.cc Loading commit data...
scanner.h Loading commit data...
token.cc Loading commit data...
token.h Loading commit data...