• Tobias Tebbi's avatar
    [compiler] make CanCover() transitive · 6048f754
    Tobias Tebbi authored
    In addition to checking that a node is owned, CanCover() also needs to
    check if there are any side-effects in between the current node and
    the merged node. When merging inputs of inputs, this check was done
    with the wrong side-effect level of the in-between node.
    We partially fixed this before with `CanCoverTransitively`.
    This CL addresses the issue by always comparing to the side-effect
    level of the node from which we started, making `CanCoverTransitively`
    superfluous.
    
    Bug: chromium:1336869
    Change-Id: I78479b32461ede81138f8b5d48d60058cfb5fa0a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3707277Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81217}
    6048f754
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
loong64 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
code-generator-impl.h Loading commit data...
code-generator.cc Loading commit data...
code-generator.h Loading commit data...
frame-elider.cc Loading commit data...
frame-elider.h Loading commit data...
gap-resolver.cc Loading commit data...
gap-resolver.h Loading commit data...
instruction-codes.h Loading commit data...
instruction-scheduler.cc Loading commit data...
instruction-scheduler.h Loading commit data...
instruction-selector-impl.h Loading commit data...
instruction-selector.cc Loading commit data...
instruction-selector.h Loading commit data...
instruction.cc Loading commit data...
instruction.h Loading commit data...
jump-threading.cc Loading commit data...
jump-threading.h Loading commit data...
mid-tier-register-allocator.cc Loading commit data...
mid-tier-register-allocator.h Loading commit data...
move-optimizer.cc Loading commit data...
move-optimizer.h Loading commit data...
register-allocation.h Loading commit data...
register-allocator-verifier.cc Loading commit data...
register-allocator-verifier.h Loading commit data...
register-allocator.cc Loading commit data...
register-allocator.h Loading commit data...
spill-placer.cc Loading commit data...
spill-placer.h Loading commit data...
unwinding-info-writer.h Loading commit data...