• Leszek Swirski's avatar
    Revert "[sfi] Remove SFI function literal id field" · b6888b63
    Leszek Swirski authored
    This reverts commit ceb9c812.
    
    Reason for revert: Tanks compile time
    
    Original change's description:
    > [sfi] Remove SFI function literal id field
    > 
    > SharedFunctionInfos store their original function literal's id. This is
    > also their index in the Script's SFI list.
    > 
    > Since the function literal id is only needed for lazy compilation and live
    > edit, we can calculate it on-the-fly by linear search in the Script SFI list,
    > and save a field on the SFI.
    > 
    > If this regresses compile performance, we could alternatively store the
    > function literal id on the preparsed scope data as future work.
    > 
    > Bug: chromium:818642
    > Change-Id: I5468cea0e115921f1c864d94e567d749a4349882
    > Reviewed-on: https://chromium-review.googlesource.com/1082480
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Hannes Payer <hpayer@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#53523}
    
    TBR=hpayer@chromium.org,leszeks@chromium.org,verwaest@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:818642
    Bug: chromium:850417
    Change-Id: If2fd21331b7062532c04004a51e705f7e9d0a151
    Reviewed-on: https://chromium-review.googlesource.com/1090494Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53573}
    b6888b63
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...