• Benedikt Meurer's avatar
    [inspector] Consistently format value wrappers in console messages. · 3b150938
    Benedikt Meurer authored
    When formatting console messages (for consumption in Chromium/Blink), we
    have special logic to unwrap value wrapper objects. But this logic was
    not very consistent, and especially Number values and NumberObject
    values were formatted differently.
    
    This changes the V8ValueStringBuilder::append() logic to always unwrap
    any value wrapper first and then use the regular dispatch for the
    primitive value.
    
    Fixed: chromium:1321833
    Change-Id: I9996671e1f91da0841e5d5f1687cf647ab72a561
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622913
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80323}
    3b150938
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...