• Clemens Hammacher's avatar
    Revert "[wasm][gc] Free WasmCode objects" · 3ad63aef
    Clemens Hammacher authored
    This reverts commit b6fb2707.
    
    Reason for revert: TSan issues, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/26177
    
    Original change's description:
    > [wasm][gc] Free WasmCode objects
    > 
    > This adds the next step to freeing code: We free the actual C++
    > {WasmCode} objects. This will cause UAF if any C++ code uses stale
    > references.
    > The underlying machine code will still not be freed.
    > 
    > For simplicity, this CL changes the vector of owned_code to an ordered
    > set, such that lookup and removal is much simpler. The drawback is that
    > insertion is now more expensive.
    > 
    > R=​mstarzinger@chromium.org
    > 
    > Bug: v8:8217
    > Change-Id: I07fc81167816637fbaad6c06ff79e3f952f2fde8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593080
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#61165}
    
    TBR=mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: I167a8d806a8c6ac1c90e0743cdf86d492389bbed
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8217, v8:9200
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593305Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61176}
    3ad63aef
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...