• Tobias Tebbi's avatar
    Revert "Reland^4 "[turbofan] eagerly prune None types and deadness from the graph"" · 2bf01995
    Tobias Tebbi authored
    This revert is manual, but almost completely automatic. 
    It was just blocked by a single-line irrelevant refactoring change.
    This reverts commit 1cee0e01.
    
    Reason for revert: chromium:776256
    
    Original change's description:
    > Reland^4 "[turbofan] eagerly prune None types and deadness from the graph"
    >
    > This fixes https://bugs.chromium.org/p/chromium/issues/detail?id=773954.
    > The issue was that in the EffectControlLinearizer, the effect input of an
    > {Unreachable} node was not updated, leaving a {Checkpoint} behind.
    >
    > This is a reland of 4cf47645
    > Original change's description:
    > > Reland^3 "[turbofan] eagerly prune None types and deadness from the graph"
    > >
    > > This fixes the issues
    > > https://bugs.chromium.org/p/chromium/issues/detail?id=772873
    > > and https://bugs.chromium.org/p/chromium/issues/detail?id=772872.
    > >
    > > One problem was that mutating an effect node into Unreachable confused
    > > the LoadElimination sidetables, so I just always create a new node now.
    > >
    > > The other problem was that UpdateBlockControl() was executed after
    > > UpdateEffectPhi() in the lazy case. This reverted the update to the Merge input.
    > > So now I make sure that UpdateEffectPhi() is always executed last.
    > >
    > > This is a reland of 6ddb5e7d
    > > Original change's description:
    > > > Reland^2 "[turbofan] eagerly prune None types and deadness from the graph"
    > > >
    > > > Now, the EffectControlLinearizer connects all occurrences of Unreachable to the
    > > > graph end. This fixes issues with later phases running DeadCodeElimination and
    > > > introducing new DeadValue nodes when processing uses of Unreachable.
    > > >
    > > > This is a reland of 3c4bc27f
    > > > Original change's description:
    > > > > Reland "[turbofan] eagerly prune None types and deadness from the graph"
    > > > >
    > > > > This is a reland of e1cdda25
    > > > > Original change's description:
    > > > > > [turbofan] eagerly prune None types and deadness from the graph
    > > > > >
    > > > > > In addition to using the {Dead} node to prune dead control nodes and nodes that
    > > > > > depend on them, we introduce a {DeadValue} node representing an impossible value
    > > > > > that can occur at any position in the graph. The extended {DeadCodeElimination}
    > > > > > prunes {DeadValue} and its uses, inserting a crashing {Unreachable} node into
    > > > > > the effect chain when possible. The remaining uses of {DeadValue} are handled
    > > > > > in {EffectControlLinearizer}, where we always have access to the effect chain.
    > > > > > In addition to explicitly introduced {DeadValue} nodes, we consider any value use
    > > > > > of a node with type {None} as dead.
    > > > > >
    > > > > > Bug: chromium:741225
    > > > > > Change-Id: Icc4b636d1d018c452ba1a2fa7cd3e00e522f1655
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/641250
    > > > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > > > > > Cr-Commit-Position: refs/heads/master@{#48208}
    > > > >
    > > > > Bug: chromium:741225
    > > > > Change-Id: I21316913dae02864f7a6d7c9269405a79f054138
    > > > > Reviewed-on: https://chromium-review.googlesource.com/692034
    > > > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#48232}
    > > >
    > > > Bug: chromium:741225
    > > > Change-Id: I5702ec34856c075717162153adc765774453c45f
    > > > Reviewed-on: https://chromium-review.googlesource.com/702264
    > > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#48366}
    > >
    > > Bug: chromium:741225
    > > Change-Id: I4054a694d2521c2e1f0c4a3ad0f3cf100b5c536f
    > > Reviewed-on: https://chromium-review.googlesource.com/709214
    > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#48469}
    >
    > Bug: chromium:741225
    > Change-Id: Id9d4f3a3ae36cb3e38f80edcdba88efa7922ca24
    > Reviewed-on: https://chromium-review.googlesource.com/715716
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#48660}
    
    TBR=jarin@chromium.org,tebbi@chromium.org,bmeurer@chromium.org
    
    
    Bug: chromium:741225 chromium:776256
    Change-Id: Iaf2af3cb6dea5fdece43297cb9d987e7decc726d
    Reviewed-on: https://chromium-review.googlesource.com/727804
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48749}
    2bf01995
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
STYLE Loading commit data...
access-builder.cc Loading commit data...
access-builder.h Loading commit data...
access-info.cc Loading commit data...
access-info.h Loading commit data...
all-nodes.cc Loading commit data...
all-nodes.h Loading commit data...
allocation-builder.h Loading commit data...
basic-block-instrumentor.cc Loading commit data...
basic-block-instrumentor.h Loading commit data...
branch-elimination.cc Loading commit data...
branch-elimination.h Loading commit data...
bytecode-analysis.cc Loading commit data...
bytecode-analysis.h Loading commit data...
bytecode-graph-builder.cc Loading commit data...
bytecode-graph-builder.h Loading commit data...
bytecode-liveness-map.cc Loading commit data...
bytecode-liveness-map.h Loading commit data...
c-linkage.cc Loading commit data...
checkpoint-elimination.cc Loading commit data...
checkpoint-elimination.h Loading commit data...
code-assembler.cc Loading commit data...
code-assembler.h Loading commit data...
code-generator-impl.h Loading commit data...
code-generator.cc Loading commit data...
code-generator.h Loading commit data...
common-node-cache.cc Loading commit data...
common-node-cache.h Loading commit data...
common-operator-reducer.cc Loading commit data...
common-operator-reducer.h Loading commit data...
common-operator.cc Loading commit data...
common-operator.h Loading commit data...
compiler-source-position-table.cc Loading commit data...
compiler-source-position-table.h Loading commit data...
control-equivalence.cc Loading commit data...
control-equivalence.h Loading commit data...
control-flow-optimizer.cc Loading commit data...
control-flow-optimizer.h Loading commit data...
dead-code-elimination.cc Loading commit data...
dead-code-elimination.h Loading commit data...
diamond.h Loading commit data...
effect-control-linearizer.cc Loading commit data...
effect-control-linearizer.h Loading commit data...
escape-analysis-reducer.cc Loading commit data...
escape-analysis-reducer.h Loading commit data...
escape-analysis.cc Loading commit data...
escape-analysis.h Loading commit data...
frame-elider.cc Loading commit data...
frame-elider.h Loading commit data...
frame-states.cc Loading commit data...
frame-states.h Loading commit data...
frame.cc Loading commit data...
frame.h Loading commit data...
gap-resolver.cc Loading commit data...
gap-resolver.h Loading commit data...
graph-assembler.cc Loading commit data...
graph-assembler.h Loading commit data...
graph-reducer.cc Loading commit data...
graph-reducer.h Loading commit data...
graph-trimmer.cc Loading commit data...
graph-trimmer.h Loading commit data...
graph-visualizer.cc Loading commit data...
graph-visualizer.h Loading commit data...
graph.cc Loading commit data...
graph.h Loading commit data...
instruction-codes.h Loading commit data...
instruction-scheduler.cc Loading commit data...
instruction-scheduler.h Loading commit data...
instruction-selector-impl.h Loading commit data...
instruction-selector.cc Loading commit data...
instruction-selector.h Loading commit data...
instruction.cc Loading commit data...
instruction.h Loading commit data...
int64-lowering.cc Loading commit data...
int64-lowering.h Loading commit data...
js-builtin-reducer.cc Loading commit data...
js-builtin-reducer.h Loading commit data...
js-call-reducer.cc Loading commit data...
js-call-reducer.h Loading commit data...
js-context-specialization.cc Loading commit data...
js-context-specialization.h Loading commit data...
js-create-lowering.cc Loading commit data...
js-create-lowering.h Loading commit data...
js-generic-lowering.cc Loading commit data...
js-generic-lowering.h Loading commit data...
js-graph.cc Loading commit data...
js-graph.h Loading commit data...
js-inlining-heuristic.cc Loading commit data...
js-inlining-heuristic.h Loading commit data...
js-inlining.cc Loading commit data...
js-inlining.h Loading commit data...
js-intrinsic-lowering.cc Loading commit data...
js-intrinsic-lowering.h Loading commit data...
js-native-context-specialization.cc Loading commit data...
js-native-context-specialization.h Loading commit data...
js-operator.cc Loading commit data...
js-operator.h Loading commit data...
js-type-hint-lowering.cc Loading commit data...
js-type-hint-lowering.h Loading commit data...
js-typed-lowering.cc Loading commit data...
js-typed-lowering.h Loading commit data...
jump-threading.cc Loading commit data...
jump-threading.h Loading commit data...
linkage.cc Loading commit data...
linkage.h Loading commit data...
live-range-separator.cc Loading commit data...
live-range-separator.h Loading commit data...
load-elimination.cc Loading commit data...
load-elimination.h Loading commit data...
loop-analysis.cc Loading commit data...
loop-analysis.h Loading commit data...
loop-peeling.cc Loading commit data...
loop-peeling.h Loading commit data...
loop-variable-optimizer.cc Loading commit data...
loop-variable-optimizer.h Loading commit data...
machine-graph-verifier.cc Loading commit data...
machine-graph-verifier.h Loading commit data...
machine-operator-reducer.cc Loading commit data...
machine-operator-reducer.h Loading commit data...
machine-operator.cc Loading commit data...
machine-operator.h Loading commit data...
memory-optimizer.cc Loading commit data...
memory-optimizer.h Loading commit data...
move-optimizer.cc Loading commit data...
move-optimizer.h Loading commit data...
node-aux-data.h Loading commit data...
node-cache.cc Loading commit data...
node-cache.h Loading commit data...
node-marker.cc Loading commit data...
node-marker.h Loading commit data...
node-matchers.cc Loading commit data...
node-matchers.h Loading commit data...
node-properties.cc Loading commit data...
node-properties.h Loading commit data...
node.cc Loading commit data...
node.h Loading commit data...
opcodes.cc Loading commit data...
opcodes.h Loading commit data...
operation-typer.cc Loading commit data...
operation-typer.h Loading commit data...
operator-properties.cc Loading commit data...
operator-properties.h Loading commit data...
operator.cc Loading commit data...
operator.h Loading commit data...
osr.cc Loading commit data...
osr.h Loading commit data...
persistent-map.h Loading commit data...
pipeline-statistics.cc Loading commit data...
pipeline-statistics.h Loading commit data...
pipeline.cc Loading commit data...
pipeline.h Loading commit data...
property-access-builder.cc Loading commit data...
property-access-builder.h Loading commit data...
raw-machine-assembler.cc Loading commit data...
raw-machine-assembler.h Loading commit data...
redundancy-elimination.cc Loading commit data...
redundancy-elimination.h Loading commit data...
register-allocator-verifier.cc Loading commit data...
register-allocator-verifier.h Loading commit data...
register-allocator.cc Loading commit data...
register-allocator.h Loading commit data...
representation-change.cc Loading commit data...
representation-change.h Loading commit data...
schedule.cc Loading commit data...
schedule.h Loading commit data...
scheduler.cc Loading commit data...
scheduler.h Loading commit data...
select-lowering.cc Loading commit data...
select-lowering.h Loading commit data...
simd-scalar-lowering.cc Loading commit data...
simd-scalar-lowering.h Loading commit data...
simplified-lowering.cc Loading commit data...
simplified-lowering.h Loading commit data...
simplified-operator-reducer.cc Loading commit data...
simplified-operator-reducer.h Loading commit data...
simplified-operator.cc Loading commit data...
simplified-operator.h Loading commit data...
state-values-utils.cc Loading commit data...
state-values-utils.h Loading commit data...
store-store-elimination.cc Loading commit data...
store-store-elimination.h Loading commit data...
type-cache.cc Loading commit data...
type-cache.h Loading commit data...
typed-optimization.cc Loading commit data...
typed-optimization.h Loading commit data...
typer.cc Loading commit data...
typer.h Loading commit data...
types.cc Loading commit data...
types.h Loading commit data...
unwinding-info-writer.h Loading commit data...
value-numbering-reducer.cc Loading commit data...
value-numbering-reducer.h Loading commit data...
verifier.cc Loading commit data...
verifier.h Loading commit data...
wasm-compiler.cc Loading commit data...
wasm-compiler.h Loading commit data...
wasm-linkage.cc Loading commit data...
zone-stats.cc Loading commit data...
zone-stats.h Loading commit data...