• Leszek Swirski's avatar
    Revert "[ic] Shadow smi_handler on LoadHandler to always be Smi" · 38a0bf1e
    Leszek Swirski authored
    This reverts commit 5f0e7dd4.
    
    Reason for revert: Turns out this isn't true: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/ic/ic.cc;l=946
    
    Original change's description:
    > [ic] Shadow smi_handler on LoadHandler to always be Smi
    >
    > StoreHandlers can store either a Code object or a Smi, so the
    > smi_handler field on DataHandler is a Code|Smi. But, LoadHandlers can
    > only store Smis here so add a shadowing smi_handler definition which
    > only allows / returns Smis.
    >
    > Change-Id: Icc1c508db268950990b9c84b9e682b9a9b1f43e5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663745
    > Commit-Queue: Igor Sheludko <ishell@chromium.org>
    > Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#80775}
    
    Change-Id: Ia2c14141ab5929be3ded883f0cecb40645a72dfd
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672419
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Owners-Override: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#80776}
    38a0bf1e
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...