• Clemens Backes's avatar
    Revert "Reland "[wasm] Refactor compilation tier computations"" · 384598dc
    Clemens Backes authored
    This reverts commit b3a27f22.
    
    Reason for revert: Fails 'debug-enabled-tier-down-wasm' flakily (https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64/48026/overview)
    
    Original change's description:
    > Reland "[wasm] Refactor compilation tier computations"
    >
    > This is a reland of commit e50472d6.
    > In {ApplyCompilationHintToInitialProgress} we would reset the baseline
    > tier to {kNone} if the compilation strategy is {kDefault}, which is
    > wrong. We would not generate code but also not install the lazy stub,
    > so whenever we start executing the code before top-tier is ready we
    > would crash.
    >
    > Original change's description:
    > > [wasm] Refactor compilation tier computations
    > >
    > > The way we initialized the "compilation progress" was pretty convoluted,
    > > with multiple levels of functions being called for initializing every
    > > single slot.
    > >
    > > This CL refactors this to compute one default value for the whole
    > > module, and only modifies those slots that need special handling (e.g.
    > > because of compilation hints, or lazy/eager compilation after
    > > deserialization).
    > >
    > > We also rename "liftoff_functions" to "eager_functions" in the
    > > deserialization path; the idea is that those functions should get
    > > eagerly compiled because we expect them to be needed during execution.
    > > Usually they would be Liftoff-compiled, but it's more consistent to use
    > > the existing logic to choose the baseline tier. In the default
    > > configuration, this will still use Liftoff, but if Liftoff is disabled
    > > we will use TurboFan instead.
    > >
    > > R=jkummerow@chromium.org, ahaas@chromium.org
    > >
    > > Bug: v8:12425
    > > Change-Id: Ie58840b19efd0b1e98f1b02d5f1d4369410ed8e1
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829606
    > > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#82521}
    >
    > Bug: v8:12425
    > Change-Id: Ie41e63148bf6bd0e38fc07a3a514f1094d9d26cf
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3838409
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82585}
    
    Bug: v8:12425
    Change-Id: Ic86d3f5b0e0603dae62ccead3be052d928209506
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3842208
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#82588}
    384598dc
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...