• Maya Lekova's avatar
    Revert "[parser] Fix caching dynamic vars on wrong scope" · 2f820780
    Maya Lekova authored
    This reverts commit 304e97d3.
    
    Reason for revert: Last roll is failing - https://ci.chromium.org/p/chromium/builders/try/linux-rel/282356
    
    Original change's description:
    > [parser] Fix caching dynamic vars on wrong scope
    > 
    > When looking up a variable in a deserialized WITH scope, we were
    > unconditionally passing in the cache scope to the lookup, even if the
    > with was inside the cache scope. This would lead to and outer scope of
    > the with holding the generated dynamic variable. If the cache scope was
    > the SCRIPT scope, the dynamic variable would be interpreted as a global
    > object property.
    > 
    > Now, we only store the WITH scope dynamic variables in the cache scope
    > if it is an inner scope of the WITH scope, same as we do for 'normal'
    > scope lookups.
    > 
    > Fixed: chromium:1041210
    > Change-Id: I4e8eb25bbb8ea58311355d13a9c7c97bf2fa3ec7
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997135
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    > Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65732}
    
    TBR=leszeks@chromium.org,verwaest@chromium.org
    
    Change-Id: I7b6d77d03b603152a9a47541db466934f46b1176
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2000140Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65747}
    2f820780
Name
Last commit
Last update
..
OWNERS Loading commit data...
ast-function-literal-id-reindexer.cc Loading commit data...
ast-function-literal-id-reindexer.h Loading commit data...
ast-source-ranges.h Loading commit data...
ast-traversal-visitor.h Loading commit data...
ast-value-factory.cc Loading commit data...
ast-value-factory.h Loading commit data...
ast.cc Loading commit data...
ast.h Loading commit data...
modules.cc Loading commit data...
modules.h Loading commit data...
prettyprinter.cc Loading commit data...
prettyprinter.h Loading commit data...
scopes.cc Loading commit data...
scopes.h Loading commit data...
source-range-ast-visitor.cc Loading commit data...
source-range-ast-visitor.h Loading commit data...
variables.cc Loading commit data...
variables.h Loading commit data...