• Andreas Haas's avatar
    [test] Make assertThrowsEquals use assertSame · 86a27207
    Andreas Haas authored
    The typical use of assertThrowsEquals is to check that a specific
    object is thrown. However, assertEquals only does a proper equality
    check for primitive types, not for complex types. Using assertSame
    does a reference equality check on objects, which is more what you
    would expect from assertThrowsEquals. For exception kind testing,
    assertThrowsEquals actually did not work correctly, assertThrows is
    better for that case.
    
    R=clemensh@chromium.org, mythria@chromium.org
    
    Change-Id: I24fb22e75fa33ebe90eb4bae40825119a054bba5
    Reviewed-on: https://chromium-review.googlesource.com/1087952Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53556}
    86a27207
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...