• Nico Hartmann's avatar
    Workaround for CFI bug · 34e89a6b
    Nico Hartmann authored
    This CL lands a workaround for a bug causing the linker to merge
    ExternalOneByteStringGetChar() and ExternalTwoByteStringGetChar() which
    leads to the generated vtable address checks failing on one of the
    inputs.
    
    To make the two function's machine code different (to prevent the
    linker from merging them), this CL adds CHECKs of the arguments to both
    functions.
    
    Bug: chromium:1160961
    Change-Id: Ifc4c6e4e05a394a6f27572877abb765d02fd23ff
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640478Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72216}
    34e89a6b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...