• Jakob Gruber's avatar
    Revert "[builtins] Support embedded builtins in nosnapshot builds" · 856be9c2
    Jakob Gruber authored
    This reverts commit bf2f0a02.
    
    Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/21753
    
    Original change's description:
    > [builtins] Support embedded builtins in nosnapshot builds
    > 
    > This CL adds support for embedded builtins in nosnap builds by creating
    > and setting an 'embedded blob' after builtin generation. Unlike
    > snapshot builds, the blob is not embedded into the .text section but
    > located on the C++ heap.
    > 
    > This makes nosnap builds more consistent with mksnapshot, and allows us
    > to simplify there and in serializer cctests.
    > 
    > Complications arise from the different workflows we need to support:
    > 
    > 1. the standard mksnapshot build process,
    > 2. nosnap builds (which reuse the blob created by the first Isolate),
    > 2. and tests with various complicated serialization workflows.
    > 
    > To cover all of these cases, this CL introduces two knobs to twiddle:
    > 
    > 1. A 'sticky' embedded blob which overrides compiled-in default
    >    embedded blobs at Isolate setup.
    > 2. The blob lifecycle can be managed manually or through refcounting.
    > 
    > These are described in more detail in isolate.cc.
    > 
    > Tbr: ulan@chromium.org
    > Bug: v8:6666, v8:8350
    > Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1310195
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#57523}
    
    TBR=ulan@chromium.org,yangguo@chromium.org,jgruber@chromium.org
    
    Change-Id: I6e35a0cb7186fb50f1012f5c618fb8b48b24a813
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:6666, v8:8350
    Reviewed-on: https://chromium-review.googlesource.com/c/1337577Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57529}
    856be9c2
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...