• Andreas Haas's avatar
    [wasm] Cleanup calls to CalculateGlobalOffsets · 960c672c
    Andreas Haas authored
    CalculateGlobalOffsets has to be called once after all globals got
    defined but before global offsets get accessed, e.g. during code
    generation. It is not clear though when exactly CalculateGlobalOffsets
    should be called. The globals section may not exist, so at the end of
    the globals section is not enough (globals can also be defined in the
    import section). At the beginning of the code section is also not good
    enough, because the code section may not exist. At the end of the module
    may be too late.
    
    With this CL, CalculateGlobalOffsets is called after the global section,
    before the code section, and at the end of the module. Additionally the CL
    checks if CalculateGlobalOffsets has already been called, so that it is
    not executed a second time.
    
    R=manoskouk@chromium.org
    
    Bug: v8:11185
    Change-Id: I922b9f60a4a17a09d2527fd9ab35cda71226030c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551100
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarManos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71314}
    960c672c
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...