• Jakob Kummerow's avatar
    Make RegExpFlagsFromString faster · 2cce5c52
    Jakob Kummerow authored
    The new ObjectPtr design makes non-inlined helper functions a little
    more expensive because "this" is always a pointer where pass-by-value
    would be more efficient, which is an issue for functions whose size puts
    them right at the threshold of getting inlined or not. String::Get falls
    into this category when called from RegExpFlagsFromString. In this case,
    we can do even better than restoring inlineability by fine-tuning
    the control flow a bit.
    
    This should repair the regression in crbug.com/910573
    
    Bug: chromium:910573
    Change-Id: Ie6b68ef01cd978ec502d8d6c1da788c77422dce7
    Reviewed-on: https://chromium-review.googlesource.com/c/1369087
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58234}
    2cce5c52
Name
Last commit
Last update
..
RegExpTests.json Loading commit data...
base.js Loading commit data...
base_ctor.js Loading commit data...
base_exec.js Loading commit data...
base_flags.js Loading commit data...
base_match.js Loading commit data...
base_replace.js Loading commit data...
base_search.js Loading commit data...
base_split.js Loading commit data...
base_test.js Loading commit data...
ctor.js Loading commit data...
exec.js Loading commit data...
flags.js Loading commit data...
inline_test.js Loading commit data...
match.js Loading commit data...
replace.js Loading commit data...
run.js Loading commit data...
search.js Loading commit data...
slow_exec.js Loading commit data...
slow_flags.js Loading commit data...
slow_match.js Loading commit data...
slow_replace.js Loading commit data...
slow_search.js Loading commit data...
slow_split.js Loading commit data...
slow_test.js Loading commit data...
split.js Loading commit data...
test.js Loading commit data...