• littledan's avatar
    Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++... · 4530f0dc
    littledan authored
    Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++ (patchset #6 id:100001 of https://codereview.chromium.org/2671233002/ )
    
    Reason for revert:
    Due to security issue described in review thread.
    
    Original issue's description:
    > [typedarrays] move %TypedArray%.prototype.copyWithin to C++
    >
    > - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
    > - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
    > relies on std::memmove rather than accessing individual eleements.
    > - Fixes the case where copyWithin is invoked on a TypedArray with a
    > detached buffer.
    > - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled correctly by the
    > algorithm
    >
    > The C++ version gets through the benchmark more than 25000 times as
    > quickly as the JS implementation.
    >
    > BUG=v8:5925, v8:5929, v8:4648
    > R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
    >
    > Review-Url: https://codereview.chromium.org/2671233002
    > Cr-Commit-Position: refs/heads/master@{#42975}
    > Committed: https://chromium.googlesource.com/v8/v8/+/0f1c626d556cbf84b0e572635eb803729f88cbb3
    
    TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,cwhan.tunz@gmail.com,caitp@igalia.com
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=v8:5925, v8:5929, v8:4648
    
    Review-Url: https://codereview.chromium.org/2693753002
    Cr-Commit-Position: refs/heads/master@{#43132}
    4530f0dc
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...