• Ng Zhi An's avatar
    Reland "[wasm-simd][liftoff][arm][arm64] Implement integer narrowing" · 050a7e05
    Ng Zhi An authored
    This relands commit 387d85ad.
    
    This was passing in the simulator because of the typo in
    simulator-arm.cc. The instr->Bit(7,6) call is incorrect, it should be
    Bit (no s). I don't really know what it resolves to, but the effect is
    that we get src_unsigned is false when we expect it to be true.
    
    With the simulator fix, we get the same error as non-simulator runs. The
    fix is in liftoff-assembler-arm.h, we need to be passing both source and
    dst data types to vmovqn. This was already done correctly in
    code-generator-arm, but I was careless in copying the logic...
    
    Bug: v8:9909
    
    Original change's description:
    > [wasm-simd][liftoff][arm][arm64] Implement integer narrowing
    >
    > Bug: v8:9909
    > Change-Id: I0664df45fe399bfa018ff8bcacdbdae66944ed29
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154834
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67254}
    
    Change-Id: If17f13aae40569174635283abec5ea1358286f55
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157799Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Auto-Submit: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67287}
    050a7e05
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
off-thread-isolate.cc Loading commit data...
off-thread-isolate.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...