• Sigurd Schneider's avatar
    Revert "Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation"" · d691fde3
    Sigurd Schneider authored
    This reverts commit d7def900.
    
    Reason for revert: Breaks UBSan:
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20UBSan/4542
    
    Besides undefined behavior, things were looking good!
    
    
    Original change's description:
    > Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation"
    > 
    > This is a reland of I968a08cef6a6d49350aa79185b2c6fb856d15f23
    > 
    > Original change's description:
    > > [builtins] [turbofan] Refactor Float64Pow to use single implementation
    > >
    > > Remove platform-specific Float64Pow implementations and utils Pow in
    > > favor of a base::ieee754::pow implementation.
    > >
    > > This unifies the implementation of pow for the compiler, wasm, and
    > > runtime.
    > >
    > > Bug: v8:5848, v8:5086
    > > Change-Id: I968a08cef6a6d49350aa79185b2c6fb856d15f23
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1403018
    > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#59229}
    > 
    > Bug: v8:5848, v8:5086
    > Change-Id: I92f22ae03adafd9ad042e8d4bb406cbd5b5fb51e
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
    > Reviewed-on: https://chromium-review.googlesource.com/c/1447854
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59411}
    
    TBR=jkummerow@chromium.org,jarin@chromium.org,neis@chromium.org,jgruber@chromium.org,clemensh@chromium.org,bmeurer@chromium.org,me@gus.host
    
    Change-Id: I65c4bbd3ab7aaa1c396d182467c5a1fe6a639df5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:5848, v8:5086
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/1456107Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59419}
    d691fde3
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
parser Loading commit data...
torque Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
allocation-unittest.cc Loading commit data...
background-compile-task-unittest.cc Loading commit data...
bigint-unittest.cc Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
code-stub-assembler-unittest.cc Loading commit data...
code-stub-assembler-unittest.h Loading commit data...
conversions-unittest.cc Loading commit data...
counters-unittest.cc Loading commit data...
detachable-vector-unittest.cc Loading commit data...
eh-frame-iterator-unittest.cc Loading commit data...
eh-frame-writer-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
microtask-queue-unittest.cc Loading commit data...
object-unittest.cc Loading commit data...
register-configuration-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-position-table-unittest.cc Loading commit data...
strings-storage-unittest.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unicode-unittest.cc Loading commit data...
unittests.status Loading commit data...
utils-unittest.cc Loading commit data...
value-serializer-unittest.cc Loading commit data...