• Maya Lekova's avatar
    Revert "[parser] Fix caching dynamic vars on wrong scope" · 2f820780
    Maya Lekova authored
    This reverts commit 304e97d3.
    
    Reason for revert: Last roll is failing - https://ci.chromium.org/p/chromium/builders/try/linux-rel/282356
    
    Original change's description:
    > [parser] Fix caching dynamic vars on wrong scope
    > 
    > When looking up a variable in a deserialized WITH scope, we were
    > unconditionally passing in the cache scope to the lookup, even if the
    > with was inside the cache scope. This would lead to and outer scope of
    > the with holding the generated dynamic variable. If the cache scope was
    > the SCRIPT scope, the dynamic variable would be interpreted as a global
    > object property.
    > 
    > Now, we only store the WITH scope dynamic variables in the cache scope
    > if it is an inner scope of the WITH scope, same as we do for 'normal'
    > scope lookups.
    > 
    > Fixed: chromium:1041210
    > Change-Id: I4e8eb25bbb8ea58311355d13a9c7c97bf2fa3ec7
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997135
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    > Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65732}
    
    TBR=leszeks@chromium.org,verwaest@chromium.org
    
    Change-Id: I7b6d77d03b603152a9a47541db466934f46b1176
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2000140Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65747}
    2f820780
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...