• pthier's avatar
    Reland "[sparkplug] Change bytecode offset mapping and introduce iterator." · 2966c896
    pthier authored
    This is a reland of a8b61ef5
    
    The main reason for the revert was not related to this CL and was fixed
    with https://crrev.com/c/2739646
    In addition debug output in d8.test.verifySourcePositions was removed
    due to TSAN complaints.
    
    Original change's description:
    > [sparkplug] Change bytecode offset mapping and introduce iterator.
    >
    > Previously, we recorded pairs of (bytecode offset, sparkplug pc) to
    > create a mapping of bytecode offset <-> sparkplug pc.
    > These pairs were only recorded after builtin/runtime calls.
    > In preparation for deoptimizing to Sparkplug, we need a more precise
    > mapping.
    > With this CL, we record positions for every bytecode. Instead of storing
    > a pair of (bytecode offset, sparkplug pc), we store only the pc,
    > calculating the bytecode offset from the index in the mapping table.
    > For easier use an iterator to access the mapping is introduced.
    >
    > Drive-by: Reduce sampling interval in cpu-profiler cctest to get rid of
    flaky failures.
    >
    > Bug: v8:11420, v8:11429
    > Change-Id: I36a9171f43a574eb67880cbca6cf9ff7ab291e60
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720189
    > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Auto-Submit: Patrick Thier <pthier@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73186}
    >
    > Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6
    
    Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745335Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73293}
    2966c896
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
external-pointer-table.cc Loading commit data...
external-pointer-table.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
local-isolate-inl.h Loading commit data...
local-isolate.cc Loading commit data...
local-isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
shared-mutex-guard-if-off-thread.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...